Add dimensions parameter to ingest method#565
Merged
Conversation
kounelisagis
force-pushed
the
agis/consider-current-domain
branch
from
September 9, 2025 15:10
efd6d46 to
22a0f6d
Compare
kounelisagis
changed the title
dimensions parameter to ingest method
kounelisagis
marked this pull request as ready for review
September 9, 2025 15:51
teo-tsirpanis
approved these changes
Sep 9, 2025
ihnorton
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
dimensionsparameter to theingestmethod to allow overriding the dimensions detected from source arrays. This fixes an issue coming from TileDB-SOMA, where dimension domains are set to~2^63and cause TileDB-Vector-Search to detect ingest the whole domain.Fixes #564
[sc-62701]